text icon indicating copy to clipboard operation
text copied to clipboard

Update pkg_helpers.bash for PyTorch 1.13 release

Open abhinavarora opened this issue 3 years ago • 4 comments

abhinavarora avatar Oct 04 '22 19:10 abhinavarora

Why is this necessary?

The current proposed change is touching the code path for nightly build. So I don't think this is correct.

Has something about the release process changed that require change in the bash script?

Hey @mthrok I was just following the step 5 from this wiki. Please let me know if this is stale?

abhinavarora avatar Oct 04 '22 20:10 abhinavarora

Can you rebase on https://github.com/pytorch/text/pull/1923 and see if it makes difference? I believe it doesn’t make a difference but let’s see.

mthrok avatar Oct 04 '22 22:10 mthrok

In the previous release, this change was made as a patch. But I believe that the correct fix is to make Arm Mac build job aware of PYTORCH_VERSION environment variable.

mthrok avatar Oct 05 '22 00:10 mthrok

Hi @abhinavarora!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Nov 18 '23 08:11 facebook-github-bot