pytorch
AG NEWS iterable dataset offsets
Codecov Report
Merging #1338 (0e7966b) into master (0435df1) will decrease coverage by
0.27%. The diff coverage is46.42%.
@@ Coverage Diff @@
## master #1338 +/- ##
==========================================
- Coverage 76.85% 76.58% -0.28%
==========================================
Files 63 63
Lines 3275 3301 +26
==========================================
+ Hits 2517 2528 +11
- Misses 758 773 +15
| Impacted Files | Coverage Δ | |
|---|---|---|
| torchtext/data/datasets_utils.py | 83.63% <42.30%> (-5.60%) |
:arrow_down: |
| torchtext/datasets/ag_news.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 0435df1...0e7966b. Read the comment docs.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Codecov Report
Merging #1338 (0e7966b) into master (0435df1) will decrease coverage by
0.27%. The diff coverage is46.42%.
@@ Coverage Diff @@ ## master #1338 +/- ## ========================================== - Coverage 76.85% 76.58% -0.28% ========================================== Files 63 63 Lines 3275 3301 +26 ========================================== + Hits 2517 2528 +11 - Misses 758 773 +15Impacted Files Coverage Δ torchtext/data/datasets_utils.py
83.63% <42.30%> (-5.60%)⬇️ torchtext/datasets/ag_news.py100.00% <100.00%> (ø)Continue to review full report at Codecov.Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 0435df1...0e7966b. Read the comment docs.
This is because I used this function to generate the offsets and hardcoded them into the AG NEWS dataset file, but the function isn't actually run otherwise. Should I remove it from the code, or add a test for it, or do something else so it is used?
