rfcs icon indicating copy to clipboard operation
rfcs copied to clipboard

RFC-0018: torch.monitor - events and counters for PyTorch

Open edward-io opened this issue 4 years ago • 2 comments

Co-authored-by: Tristan Rice [email protected]

edward-io avatar Oct 15 '21 00:10 edward-io

FYI for anyone following this: I'm currently implementing this in pytorch and following this RFC and the comments as much as possible. Once I get a good working POC I'll update this RFC before landing it. There's a handful of differences to make implementation easier / cleaner

Here's the C++ events initial implementation: https://github.com/pytorch/pytorch/pull/68783

d4l3k avatar Dec 03 '21 21:12 d4l3k

Hi @edward-io!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Nov 09 '22 23:11 facebook-github-bot