pytorch
RFC for profile directed typing using Monkeytype tool in TorchScript
The content of this is good, but I saw some repeated mistakes that I would like to address before publishing this:
- Mismatched subjects. For example, either the third-person singular or the imperative is fine when describing what code does/should do, but please choose one and stick with it.
- Too many filler words, e.g. "very", "a lot", etc. I think it's good style to limit filler words in professional writing
- Incorrect use of commas
- Run-on sentences (related to the above point)
- Links to FB-internal sources
- Lack of Markdown formatting. In particular, please put backticks around all code and format links
- Sentences vs. sentence fragments. Either one is fine for bullet points, but choose one and stick with it
Note that, per my comments, I did NOT flag all instances of the above mistakes. It would have been too messy if I did that, and I didn't want to overload you by requesting the same changes repeatedly. Please keep your eye out for the above mistakes when you're fixing the other things I requested.
Overall good work! Thanks again for writing this up
Hi @nikithamalgifb!
Thank you for your pull request.
We require contributors to sign our Contributor License Agreement, and yours needs attention.
You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
