pytorch_sphinx_theme
pytorch_sphinx_theme copied to clipboard
Update top nav to align with #1576
Sync with the top nav changes in https://github.com/pytorch/pytorch.github.io/pull/1576
Local testing:
https://github.com/pytorch/pytorch_sphinx_theme/assets/5317992/30f9afcc-7236-4258-a103-2621b3c2d28d
A few comments:
- I would make the mouse-pointer normal
cursor: default;for the topnav elements with dropdown menus since they are not clickable as mentioned here - It's a bit hard to tell from the video but I think you need to turn the titles of each page to
#212529; they are looking a bit too light - The dropdown menus seem wider and to the left of the ones I configured on this dev site but not sure if that's a problem
- Could you show the mobile menu?
- Some items on the Blog & News menu seem to have a larger top margin, like a white gap above the title
- Blog & News is missing a "Community Stories" menu item
- Could you copy the hover states for "Join" and the GH logo from this dev site?
- Was it intentional to not include the search icon?
- I would make the mouse-pointer normal
cursor: default;for the topnav elements with dropdown menus since they are not clickable as mentioned here - ✅ - It's a bit hard to tell from the video but I think you need to turn the titles of each page to
#212529; they are looking a bit too light - ✅ - The dropdown menus seem wider and to the left of the ones I configured on this dev site but not sure if that's a problem - I think the width is actually same - 300px which seems to be consistent with the changes.
- Could you show the mobile menu? - updated the video ✅
- Some items on the Blog & News menu seem to have a larger top margin, like a white gap above the title - ✅
- Blog & News is missing a "Community Stories" menu item - ✅
- Could you copy the hover states for "Join" and the GH logo from this dev site? - ✅
- Was it intentional to not include the search icon? - we have a search bar in the left nav of the sphinx doc theme.