Don't copy name_to_input in OutputGraph
This copy isn't necessary and regressed tracing Adam by ~10s with a 1000 parameter model.
cc @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @chunyuan-w @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire
:link: Helpful Links
:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/93034
- :page_facing_up: Preview Python docs built from this PR
- :page_facing_up: Preview C++ docs built from this PR
- :question: Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours
Note: Links to docs will display an error until the docs builds have been completed.
:x: 1 Failures
As of commit f11c5413cbce5c62a9bf0c6a03241ebc03929f21:
This comment was automatically generated by Dr. CI and updates every 15 minutes.
@pytorchbot merge -f "Unrelated test failure"
Merge started
Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).
Learn more about merging in the wiki.
Questions? Feedback? Please reach out to the PyTorch DevX TeamAdvanced Debugging
Check the merge workflow status
here
jolly good show, I was wondering about what this was used for lol
Yee, it's already managed properly in restore, so it doesn't need to be saved basically nodes that are removed during rollback will get removed from the map too.
This is also used for generating unique input names quickly when adding inputs