pytorch icon indicating copy to clipboard operation
pytorch copied to clipboard

Update state_dict docs

Open Atcold opened this issue 3 years ago • 2 comments

  • Better definition of state_dict
  • Additional shallow copy warning

Atcold avatar Aug 09 '22 20:08 Atcold

:link: Helpful links

:white_check_mark: No Failures (0 Pending)

As of commit c3bc848d3a (more details on the Dr. CI page):

Expand to see more

:green_heart: :green_heart: Looks good so far! There are no failures yet. :green_heart: :green_heart:


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

facebook-github-bot avatar Aug 09 '22 20:08 facebook-github-bot

Also, related (maybe I should create a separate issue), add a copy() method to the state_dict 'object'. It doesn't make sense to import another library (copy) to make a copy of a network's state.

Atcold avatar Aug 09 '22 20:08 Atcold

@pytorchbot merge

jbschlosser avatar Aug 10 '22 19:08 jbschlosser

@pytorchbot successfully started a merge and created land time checks. See merge status here and land check progress here.

pytorchmergebot avatar Aug 10 '22 19:08 pytorchmergebot

Hey @Atcold. You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'. For changes that are 'topic: not user facing' there is no need for a release notes label.

github-actions[bot] avatar Aug 10 '22 22:08 github-actions[bot]

Why do PRs get closed rather than merged?

Atcold avatar Aug 18 '22 18:08 Atcold

just an infrastructure thing

soumith avatar Aug 18 '22 19:08 soumith