pytorch icon indicating copy to clipboard operation
pytorch copied to clipboard

Dont use constant mask if ynumel potentially overflows ygrids

Open kundaMwiza opened this issue 1 year ago • 6 comments

If (ynumel / YBLOCK) > get_max_ygrids(), the z dimension will be used if znumel is None. However, if (ynumel / YBLOCK) % get_max_ygrids() != 0, there will be program launches with inputs that require masking, and so this needs to be considered when determining if the y dimension has a constant mask.

Fixes #ISSUE_NUMBER

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov

kundaMwiza avatar Nov 05 '24 12:11 kundaMwiza

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/139751

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: You can merge normally! (3 Unrelated Failures)

As of commit 26e745b724d130e5e2fbf26d452a34158de3c918 with merge base 5deca07c0dcf1482eba99bf93b805cf1cc41ad6c (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Nov 05 '24 12:11 pytorch-bot[bot]

@pytorchbot label 'topic: not user facing'

kundaMwiza avatar Nov 05 '24 12:11 kundaMwiza

This should work but I'll let @eellison to comment if there can be better ways to handle constant ymask.

shunting314 avatar Nov 08 '24 20:11 shunting314

@pytorchbot merge

kundaMwiza avatar Nov 20 '24 22:11 kundaMwiza

Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra.

pytorch-bot[bot] avatar Nov 20 '24 22:11 pytorch-bot[bot]

@eellison Can you approve the workflows? Thanks

kundaMwiza avatar Nov 20 '24 22:11 kundaMwiza

@pytorchbot merge

kundaMwiza avatar Nov 21 '24 08:11 kundaMwiza

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging Check the merge workflow status here

pytorchmergebot avatar Nov 21 '24 08:11 pytorchmergebot

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_9-cuda12_6-test / test

Details for Dev Infra team Raised by workflow job

pytorchmergebot avatar Nov 21 '24 11:11 pytorchmergebot

@eellison Looks like an unrelated failure

kundaMwiza avatar Nov 21 '24 15:11 kundaMwiza

@pytorchbot merge

kundaMwiza avatar Nov 25 '24 09:11 kundaMwiza

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging Check the merge workflow status here

pytorchmergebot avatar Nov 25 '24 09:11 pytorchmergebot

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_9-cuda12_6-test / test

Details for Dev Infra team Raised by workflow job

pytorchmergebot avatar Nov 25 '24 09:11 pytorchmergebot

@pytorchbot merge

kundaMwiza avatar Nov 26 '24 16:11 kundaMwiza

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging Check the merge workflow status here

pytorchmergebot avatar Nov 26 '24 16:11 pytorchmergebot

Merge failed

Reason: 3 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

pytorchmergebot avatar Nov 26 '24 16:11 pytorchmergebot

@pytorchbot rebase

eellison avatar Nov 27 '24 18:11 eellison

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot avatar Nov 27 '24 18:11 pytorchmergebot

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch push -f https://github.com/graphcore/pytorch-fork.git pull/139751/head:mwizak/fix-constant-mask-large-triton-grids returned non-zero exit code 128

remote: Permission to graphcore/pytorch-fork.git denied to pytorchmergebot.
fatal: unable to access 'https://github.com/graphcore/pytorch-fork.git/': The requested URL returned error: 403

This is likely because the author did not allow edits from maintainers on the PR or because the repo has additional permissions settings that mergebot does not qualify. Raised by https://github.com/pytorch/pytorch/actions/runs/12055871747

pytorchmergebot avatar Nov 27 '24 18:11 pytorchmergebot

@pytorchbot merge

kundaMwiza avatar Dec 02 '24 13:12 kundaMwiza

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging Check the merge workflow status here

pytorchmergebot avatar Dec 02 '24 13:12 pytorchmergebot

Merge failed

Reason: 3 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

pytorchmergebot avatar Dec 02 '24 13:12 pytorchmergebot

@pytorchbot merge

eellison avatar Dec 03 '24 22:12 eellison

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging Check the merge workflow status here

pytorchmergebot avatar Dec 03 '24 22:12 pytorchmergebot