pytorch
docs: note DC-GAN combined backward fix (closes #418)
Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [x] Docs change / refactoring / dependency upgrade
Motivation and Context / Related issue
This PR closes issue [#418] by adding a note to examples/dcgan.py that the DC-GAN example now uses a single combined backward pass to avoid double-charging the privacy budget. This makes it clear to users and maintainers that the double‐charge bug has been addressed.
https://github.com/pytorch/opacus/issues/418
How Has This Been Tested (if it applies)
Documentation only change; no code behavior altered. Manually verified that the example still runs without errors under the usual settings.
Checklist
- [x] The documentation is up-to-date with the changes I made.
- [x] I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
- [ ] All tests passed, and additional code has been covered with new tests.
Hi @sisird864!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Noob question, it seems PR(https://github.com/pytorch/opacus/pull/494) is on the fly, which means the problem has not been solved yet?
@HuanyuZhang, PR #494 mentions PR #474 as solving the same issue with the privacy budget, so it seems the issue is indeed solved?
