pytorch
make CollectTrace for profiling by iteration async
This fix issue #953. Makes libkineto::api().client()->stop() and stopTraceInternal run in profilerThread_ so that, the training process will not be blocked.
Thank you for those helpful tips, I'll improve this pr as comments advised.
@briancoutinho It seems this pr is ignored after last commit. I've rebased master branch, please take some time to re-review this pr, thank you.
Hi, sorry am out for 1 1/2 week, will take a look once I'm back. you can also ask @ sraikund16 for a review
Thx
On Fri, Aug 30, 2024 at 12:38 AM Augusto Yao @.***> wrote:
@briancoutinho https://github.com/briancoutinho It seems this pr is ignored after last commit. I've rebased master branch, please take some time to re-review this pr, thank you.
— Reply to this email directly, view it on GitHub https://github.com/pytorch/kineto/pull/966#issuecomment-2320356244, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUZ7ZCZM47WFP4YYUGFAELZUAOOLAVCNFSM6AAAAABLQGOI7GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRQGM2TMMRUGQ . You are receiving this because you were mentioned.Message ID: @.***>
@staugust sorry I didn't notice this. Let me take a look later today. Thanks for your patience!
@sraikund16 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@sraikund16 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@sraikund16 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@sraikund16 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@sraikund16 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
Looks good, should we add any new test cases?
I don't see any functional tests with on-demand so its hard to test it any other way than the unit tests that I changed in this PR
@sraikund16 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@sraikund16 merged this pull request in pytorch/kineto@7a2a167b7233e3a0294c2ebb94c458cccfed7f42.