executorch icon indicating copy to clipboard operation
executorch copied to clipboard

[executorch] Migrate runtime/core to new namespace

Open dbort opened this issue 1 year ago • 4 comments

Stack from ghstack (oldest at bottom):

  • #4621
  • #4620
  • #4619
  • #4618
  • #4617
  • #4616
  • #4615
  • #4614
  • #4613
  • #4612
  • #4611
  • #4610
  • #4609
  • #4608
  • -> #4607
  • #4606
  • #4605

Migrate these headers to the new ::executorch::runtime namespace. Add temporary aliases from the old ::torch::executor namespace so we can migrate users incrementally.

The tests for these headers are updated in the next diff to help demonstrate that the backwards-compatibility aliases work.

Because EValue changed namespaces, I also needed to update print_evalue: the operator<<() for a type needs to live in its primary namespace. This shows that the aliases aren't perfect, but very few other users should be defining their own operator<< for our types. This is the only scenario where I've seen the namespace aliases break down.

Differential Revision: D60428951

dbort avatar Aug 09 '24 00:08 dbort

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4607

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: You can merge normally! (4 Unrelated Failures)

As of commit b1e29db9e2254117a0f1cd38c15c085b18033cdf with merge base 5d151d05bd9da61110941247d78f23ba911e4d32 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Aug 09 '24 00:08 pytorch-bot[bot]

This pull request was exported from Phabricator. Differential Revision: D60428951

facebook-github-bot avatar Aug 09 '24 00:08 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D60428951

facebook-github-bot avatar Aug 09 '24 02:08 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D60428951

facebook-github-bot avatar Aug 09 '24 19:08 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D60428951

facebook-github-bot avatar Aug 14 '24 23:08 facebook-github-bot