executorch icon indicating copy to clipboard operation
executorch copied to clipboard

Use single rounding as default for TOSA lowering

Open SaoirseARM opened this issue 1 year ago • 4 comments

  • Use single rounding at rescale to int8
  • Minor refactor of op_addmm to use shared functions

SaoirseARM avatar Aug 08 '24 09:08 SaoirseARM

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4591

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit d65506588d7fd43c825ea80df17bbfa44a47b17b with merge base 9a4f32d56e33fef00d09c7a8e259ebeea66f1d78 (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Aug 08 '24 09:08 pytorch-bot[bot]

@pytorchbot label 'partner: arm'

SaoirseARM avatar Aug 08 '24 09:08 SaoirseARM

@pytorchbot label ciflow/trunk

SaoirseARM avatar Aug 08 '24 09:08 SaoirseARM

Can't add following labels to PR: ciflow/trunk. Please ping one of the reviewers for help.

pytorch-bot[bot] avatar Aug 08 '24 09:08 pytorch-bot[bot]

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Aug 13 '24 22:08 facebook-github-bot