executorch icon indicating copy to clipboard operation
executorch copied to clipboard

[ET-VK][12/n] aten.cat with more codegen

Open yipjustin opened this issue 1 year ago • 6 comments

Stack from ghstack (oldest at bottom):

  • -> #3388
  • #3351
  1. The aten.cat operation are very straightforward using the copy_*_node.
  2. Complexity comes from the code-gen. We need to introduce a AT_TENSOR_LIST type, which contains a list of AT_TENSOR with is_in=True. The tensor list itself as a container is not an IOValueRef, but the element inside are. It leads to some ugly if-then-else in the codegen.

Differential Revision: D56626865

yipjustin avatar Apr 27 '24 07:04 yipjustin

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3388

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: No Failures

As of commit f63bd46bc1fe6442481136680cec6f504f5e31a9 with merge base e5471a5a7ade0f09b383e9ef1403cff73a0ccd1f (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Apr 27 '24 07:04 pytorch-bot[bot]

This pull request was exported from Phabricator. Differential Revision: D56626865

facebook-github-bot avatar Apr 27 '24 07:04 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56626865

facebook-github-bot avatar Apr 27 '24 07:04 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56626865

facebook-github-bot avatar Apr 27 '24 08:04 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56626865

facebook-github-bot avatar Apr 27 '24 21:04 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56626865

facebook-github-bot avatar Apr 27 '24 21:04 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56626865

facebook-github-bot avatar Apr 29 '24 00:04 facebook-github-bot

This pull request was exported from Phabricator. Differential Revision: D56626865

facebook-github-bot avatar Apr 29 '24 01:04 facebook-github-bot

This pull request has been merged in pytorch/executorch@fac1ae66410e1240d8a365255e01622810812f86.

facebook-github-bot avatar Apr 29 '24 02:04 facebook-github-bot