examples icon indicating copy to clipboard operation
examples copied to clipboard

please use longer names for variables than 2-3 letter acronyms

Open bionicles opened this issue 7 years ago • 2 comments

it is hard to understand the variable names in the dcgan example

would it be possible to add more clear names and descriptions?

this way we could more easily fiddle with this and it would be more useful

bionicles avatar Jan 03 '19 04:01 bionicles

@bionicles i think it is explanatory except this https://github.com/pytorch/examples/blob/e0929a4253f9ae6ccdde24e787788a9955fdfe1c/dcgan/main.py#L232 might cause trouble

surgan12 avatar Jan 04 '19 08:01 surgan12

Hi @bionicles I'd suggest flagging the variables you had trouble understanding and feel free to make the PR and I'll merge

msaroufim avatar Mar 10 '22 00:03 msaroufim