TensorRT icon indicating copy to clipboard operation
TensorRT copied to clipboard

feat: rewriting param to a Constant if it's a introduced input

Open bowang007 opened this issue 3 years ago • 1 comments

Signed-off-by: Bo Wang [email protected]

Description

In some cases, some parameters are graphs' input. We can rewrite them into constants to make sure it works.

Fixes #1190

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • [ ] My code follows the style guidelines of this project (You can use the linters)
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have added tests to verify my fix or my feature
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] I have added the relevant labels to my PR in so that relevant reviewers are notified

bowang007 avatar Aug 22 '22 20:08 bowang007

@bowang007 seems like linting is failing, can you set up the pre-commit system?

narendasan avatar Aug 23 '22 01:08 narendasan

This PR should be good to merge. @narendasan @peri044

bowang007 avatar Oct 19 '22 05:10 bowang007