code-generator icon indicating copy to clipboard operation
code-generator copied to clipboard

Update Docker Readme to include instructions for Low Disk Storage problem

Open ShatilKhan opened this issue 2 years ago • 6 comments

Description

I've added a link to this hackmd post in the docker readme on how to setup the environment in case of low storage on C Drive

What is the purpose of this pull request?

  • [ ] Bug fix
  • [ ] New feature
  • [X] Other (Documentation Update)

cc: @vfdev-5

ShatilKhan avatar Dec 25 '23 14:12 ShatilKhan

Deploy request for code-generator pending review.

Visit the deploys page to approve it

Name Link
Latest commit e296caeb8f6150870f17984de0f4b0cce5194118

netlify[bot] avatar Dec 25 '23 14:12 netlify[bot]

@ShatilKhan I think it would be better to incorporate the text from hackmd into this README directly.

vfdev-5 avatar Dec 25 '23 19:12 vfdev-5

I was actually thinking the same thing Then I'll add the hackmd text on my next commit

ShatilKhan avatar Dec 25 '23 19:12 ShatilKhan

@ShatilKhan any updates on this PR?

vfdev-5 avatar Jan 15 '24 11:01 vfdev-5

@ShatilKhan any updates on this PR?

Yes I'm working on it, I'll update it soon

ShatilKhan avatar Jan 15 '24 11:01 ShatilKhan

@ShatilKhan thanks for the update, but the content starting from horizontal line and the text "After setting up Docker and whatever the issue with space and docker is:" does not look neat and more like a dump various notes. Can you restructure such that it keeps existing logic of headers levels and the content logic, also fix the indents in the vscode config?

Here is how it looks like now: https://github.com/pytorch-ignite/code-generator/blob/e296caeb8f6150870f17984de0f4b0cce5194118/docker/readme.md

vfdev-5 avatar Jan 23 '24 09:01 vfdev-5