mltu icon indicating copy to clipboard operation
mltu copied to clipboard

Fixed checking length for symbolic tensor + make Model2onnx agnostic to the type of model

Open seidnerj opened this issue 10 months ago • 3 comments

seidnerj avatar Mar 16 '25 16:03 seidnerj

Hmm, everything look great, except that you removed try except, I am not sure if I am happy with this part

pythonlessons avatar Mar 17 '25 11:03 pythonlessons

The problem with this try/except is that it just hides the problem, instead of failing and having the user handle this exception and decide what to do, it just prints the exception and continues. If something goes wrong - it should be handled by the user.

seidnerj avatar Mar 19 '25 06:03 seidnerj

sounds logic, I'll check it, I planned to refactor this package to be compatible with latest tensorflow version

pythonlessons avatar Mar 27 '25 10:03 pythonlessons