junction icon indicating copy to clipboard operation
junction copied to clipboard

Remove uwsgi from application dependencies

Open palnabarun opened this issue 5 years ago • 9 comments

uwsgi is installed by default using other means in the virtualenv used by junction. There is no need to install uwsgi through the application dependencies.

The support for uwsgi is flaky at best on Windows and works with very limited functionality. Hence, this breaks development velocity for people developing Junction on Windows.

Ref: #651

Closes #651

palnabarun avatar Jun 05 '20 15:06 palnabarun

Closing and reopening for satisfying Travis CI. :disappointed:

palnabarun avatar Jun 05 '20 17:06 palnabarun

Just a wild guess, but won't squashing an empty commit also trigger the CI?

sayanchowdhury avatar Jun 06 '20 20:06 sayanchowdhury

@sayanchowdhury -- It should even if I amend the commits and force push. The problem is with Travis CI not even getting the events. :man_shrugging:

palnabarun avatar Jun 06 '20 22:06 palnabarun

Hmm, weird.

sayanchowdhury avatar Jun 07 '20 10:06 sayanchowdhury

@palnabarun I think it will be good to move this to a separate requirements-prod.txt until we have a proper dependency management tool.

ananyo2012 avatar Jun 07 '20 15:06 ananyo2012

I think it will be good to move this to a separate requirements-prod.txt until we have a proper dependency management tool.

Well, uwsgi is going to go away soon in the new setup. uwsgi is not related to the Junction application and should not be there in the project at all.

palnabarun avatar Jun 07 '20 18:06 palnabarun

Isn't uswgi needed in production ?

ananyo2012 avatar Jun 07 '20 18:06 ananyo2012

Isn't uswgi needed in production ?

Yes. It is, but not installed using this project's requirements.

palnabarun avatar Jun 07 '20 19:06 palnabarun

Well it's good to have a separate prod-requirements.txt than to manually install production packages

ananyo2012 avatar Jun 13 '20 05:06 ananyo2012