junction icon indicating copy to clipboard operation
junction copied to clipboard
verified publisher icon pythonindia

Have minimum words in the public comment

Open kracekumar opened this issue 8 years ago • 9 comments

Like Stack Overflow, implement minimum words for a comment. The good count is 15 words.

kracekumar avatar Jun 19 '17 17:06 kracekumar

@kracekumar Are you referring to minimum chars?

sivaa avatar Jun 23 '17 14:06 sivaa

@sivaa Oh, yes. But 15 characters is low but can be configurable.

kracekumar avatar Jun 23 '17 14:06 kracekumar

@kracekumar I am new to open source and would like to contribute to this project. Can I work on this issue?

prakharchoudhary avatar Jun 25 '17 08:06 prakharchoudhary

Please go ahead @prakharchoudhary

ChillarAnand avatar Jun 25 '17 11:06 ChillarAnand

@prakharchoudhary We'd love to have new contributors. Like @ChillarAnand said, please go ahead and start the work.

  1. The check needs to be in both client and server side.
  2. The UI should display a minimum number of required words before the user starts typing.

Feel free to discuss, doubts, and your plan.

kracekumar avatar Jun 26 '17 09:06 kracekumar

@kracekumar I have added the required changes locally. However, Flake8 keeps giving me errors for star-imports in files like .settings/dev.py. So should I correct them or ignore them before making my PR?

prakharchoudhary avatar Jun 29 '17 18:06 prakharchoudhary

@prakharchoudhary Use # noqa: ignore=F405 as a comment in star imports line to ignore flake8.

RishabhJain2018 avatar Jun 30 '17 06:06 RishabhJain2018

Hey guys, what is the status of this issue. Willing to take it up if required.

onlinejudge95 avatar Apr 11 '19 14:04 onlinejudge95

Hey @onlinejudge95, the PR #537 has been already submitted for this. We can test it ourselves, and merge if it looks good

zerothabhishek avatar Apr 12 '19 05:04 zerothabhishek