inpycon2017 icon indicating copy to clipboard operation
inpycon2017 copied to clipboard

[Fix #72] Hero screen size for all viewports

Open sagarchoudhary96 opened this issue 8 years ago • 14 comments

screenshot from 2017-08-03 12-11-24

The hero screen was overflowing on mobile screens so i made it's height to 100vh so that it looks same on all devices. Below is the updated screenshot:

screenshot from 2017-08-03 12-15-13

sagarchoudhary96 avatar Aug 03 '17 06:08 sagarchoudhary96

you can view the updated version here.

sagarchoudhary96 avatar Aug 03 '17 19:08 sagarchoudhary96

@theskumar fixed the conflicts and provided live version link too

sagarchoudhary96 avatar Aug 05 '17 04:08 sagarchoudhary96

@realslimshanky @theskumar please see to it

sagarchoudhary96 avatar Aug 08 '17 01:08 sagarchoudhary96

@sagarchoudhary96 problem with your fix is that it'll now work with the screen with small devices. All the buttons get cramped into little space on the screen and it does not look good. Exhibit A image

realslimshanky avatar Aug 08 '17 08:08 realslimshanky

@realslimshanky but i think it looks better and the button were having that much magin before too i just made the blue scren size too 100vh which didn't changed any no decreased the distances between buttons too

sagarchoudhary96 avatar Aug 09 '17 18:08 sagarchoudhary96

Sure. I would wait for others to review.

realslimshanky avatar Aug 10 '17 13:08 realslimshanky

@realslimshanky is anybody looking to these PR's ?

sagarchoudhary96 avatar Aug 12 '17 16:08 sagarchoudhary96

@CuriousLearner @sayanchowdhury would you like to have a look into this?

realslimshanky avatar Aug 12 '17 16:08 realslimshanky

@realslimshanky seems like no one looked at it. It would be great if you can see to it and let me know if required what changes to be made ?

sagarchoudhary96 avatar Aug 18 '17 07:08 sagarchoudhary96

@CuriousLearner I have made the required changes.

sagarchoudhary96 avatar Aug 19 '17 05:08 sagarchoudhary96

@realslimshanky @CuriousLearner would be great if you can look to it

sagarchoudhary96 avatar Aug 23 '17 20:08 sagarchoudhary96

@SaptakS removed it. I created it to use it in the index.html but later on i fixed it by making changes in css only. Just forgot to remove it. now it is removed.

sagarchoudhary96 avatar Aug 24 '17 06:08 sagarchoudhary96

@realslimshanky done👍

sagarchoudhary96 avatar Aug 26 '17 16:08 sagarchoudhary96

@CuriousLearner it has been too long please see to it

sagarchoudhary96 avatar Oct 04 '17 12:10 sagarchoudhary96