Anand B Pillai
Anand B Pillai
Here is an implementation of MACD in the same PR. See attached figure. 
@fmilthaler - Added documentation and unit test. Let me know if this looks good.
> Hey, thank you for adding those. I've already merged your branch into FinQuant's branch `feature/rsi-indicator` so that I could play around with it myself. Could you open a new...
Hi @fmilthaler - Any updates on if/when you may merge this ? Thank you.
Do you want me to modify the code ?
@fmilthaler - I have been out of touch for a while, due to work and just looked back at this. Didn't see the review request my bad. Kindly let me...
@fmilthaler - Not sure if it helps, but I am user of the package as well and the functions to build portfolio did not work for me by default. They...
I just saw the (slightly weird) dependency on Ruby after building `libvarnam` and felt the same. Also this is not mentioned anywhere in the README which is a bigger problem....
You probably need a type check like this before the assignment, ``` if (!PyObject_TypeCheck(instance, type)) { PyErr_Format( PyExc_TypeError, "%s._weak_cache.setdefault() returned %s, expected %s", ((PyTypeObject *)type)->tp_name, Py_TYPE(instance)->tp_name, type->tp_name ); Py_DECREF(instance); return...