arcade icon indicating copy to clipboard operation
arcade copied to clipboard
verified publisher icon pythonarcade

Seperated Slider, added UITexturedSlider

Open gran4 opened this issue 2 years ago • 3 comments

Let me know what you think. I don't want to have to add all the extra code when I implement TexturedSlider

gran4 avatar May 10 '23 22:05 gran4

I will have a deeper look into this, one thing that jumps into my mind: UISliders are interactive components and should make use of UIInteractiveWidget. Maybe it is possible to combine this.

eruvanos avatar May 18 '23 11:05 eruvanos

I will have a deeper look into this, one thing that jumps into my mind: UISliders are interactive components and should make use of UIInteractiveWidget. Maybe it is possible to combine this.

@eruvanos , that does not seem helpful in this case.

gran4 avatar Jun 03 '23 06:06 gran4

Hi, I had a deeper look into the changes now (took me way to long). I validated the idea of extracting a _SliderParent but the current implementation does not make use of it. As it is marked as an internal class, it does also not provide benefits for other game devs at the moment.

But I will check, if I can change it a little, so UITextureSlider and UI(Styled)Slider can have a abstract base class.

Thank you for your input and patience. I will check what I take over to finish the UISliders for 3.0.

eruvanos avatar Feb 13 '24 17:02 eruvanos

The slider changes are merged. Thanks again for your input!

eruvanos avatar Apr 14 '24 20:04 eruvanos