typeshed icon indicating copy to clipboard operation
typeshed copied to clipboard

gunicorn 23.0.0, draft

Open pajod opened this issue 3 months ago • 3 comments

for @eugeneliukindev

questions:

  • why the SyncWorker.wait integer return type (found nothing in commit https://github.com/eugeneliukindev/typeshed/commit/f23abec8a85c483873b8eed9cf3ce63aa5715a87)?

notes on things I would like to modify:

  • match stdlib wsgiref in that start_response accepts optional exc_info
  • FileWrapper.__getitem__ is odd, mark the argument Never
  • restrict load_class to only classes it is used for via gunicorn.conf.py
  • clarify that write_error shall not inject arbitrary str data
  • most timeout are actually float not int, and gunicorn/workers/sync.py actually uses this
  • timeout_ctx must return a context wrapper
  • overriding ThreadWorker.poller is legitimate
  • handle_request(listener_name) can be either (addr,port) tuples or string (e.g. UNIX sockets)

pajod avatar Oct 25 '25 22:10 pajod

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

github-actions[bot] avatar Oct 25 '25 22:10 github-actions[bot]

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

github-actions[bot] avatar Oct 25 '25 23:10 github-actions[bot]

@pajod Thank you for finding the inconsistencies and correcting them. I did make a mistake while doing PR.

eugeneliukindev avatar Oct 26 '25 07:10 eugeneliukindev