typeshed
typeshed copied to clipboard
gunicorn 23.0.0, draft
for @eugeneliukindev
questions:
- why the SyncWorker.wait integer return type (found nothing in commit https://github.com/eugeneliukindev/typeshed/commit/f23abec8a85c483873b8eed9cf3ce63aa5715a87)?
notes on things I would like to modify:
- match stdlib wsgiref in that start_response accepts optional exc_info
-
FileWrapper.__getitem__is odd, mark the argumentNever - restrict
load_classto only classes it is used for viagunicorn.conf.py - clarify that
write_errorshall not inject arbitrary str data - most
timeoutare actually float not int, andgunicorn/workers/sync.pyactually uses this -
timeout_ctxmust return a context wrapper - overriding
ThreadWorker.polleris legitimate -
handle_request(listener_name)can be either (addr,port) tuples or string (e.g. UNIX sockets)
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
@pajod Thank you for finding the inconsistencies and correcting them. I did make a mistake while doing PR.