Added annotation for five functions in Authlib
I have added five annotation in Authlib Not sure how to annotate returning request function of AsyncOAuth1Mixin class It seem returning Response object from request library. I am not sure how to annotate it correctly Can I write it like this? async def request(self, method, url: str, token: dict[str, Any] | None =None, **kwargs): -> Response ...
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
I am especially doubting if i must import Request?
I have look in existing stubs and I found how to do it. Hopefully it is correct. If something wrong - please teIll me - I will fix it
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
Some tests failed I have googled and added to Response import # type: ignore[import-untyped] Now all test are passed but I dont know is this trick a legal one
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
I have added httpx in dependencies and annotated kwargs
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
Please, add new entries to the allowedlist for now
Do I need to do something ro fix the tests?
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
Hello. I have problems that I cannot solve myself for getting two remaining test to work.
Authlib requires cryptography for work. I have installed if on my local machine and all tests runs OK. I have googled and it reccomended to put it in /requirements-tests.txt Tried to do it in PR - this test are passed but appeared a lot of other error in other stub files. I thought that it was bad idea and removed it back from requirements-tests. I dont know where to put it correctly. In requirements-tests.txt there is no similar libraries and i think iiit is not the right place
As previously mentioned tests found many errors in other files. After this PR I can try work, on it. Sorry for many commit and large post.
Just add new errors to https://github.com/python/typeshed/blob/main/stubs/Authlib/%40tests/stubtest_allowlist.txt with a TODO comment that they need to be handled later (you can do this in the next PR).
@srittau can you please help with the stub_uploader failed job? I've submitted a PR with httpx addition :)
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
@sobolevn I've added entries in stubtest_allowlist.txt and I will work it in next PR but I cannot resolve the remaining two test. Must I just wait? I am also tried te setup this tests on local machine but without success. Is it possible?
@sobolevn thanks for corrected me.Also I have succesfully setup stub_ uploader on local machine. Hopefully it will help me in future PRs.