typeshed icon indicating copy to clipboard operation
typeshed copied to clipboard

Rewrote protobuf generation scripts in Python

Open Avasam opened this issue 1 year ago • 0 comments

Closes #12511

This is so much faster on Windows, takes a few seconds to run (including downloads and pre-commit). Compared to the over 1m it used to take me on WSL.

I have two design questions:

  1. Which usage do we prefer:
# A)
python scripts/sync_proto/tensorflow.py

# B)
python scripts/sync_proto.py tensorflow
# Which I could make work with the following for shell autocomplete
python scripts/sync_proto.py ./stubs/tensorflow
  1. Should I add a parametrized main function (something like sync_stubs_with_proto) that takes all of a scripts' special needs as parameters (including a "post-run" Callable). Or keep the 3 scripts separate with shared helper functions.

I'm also open to name changes suggestions.

Avasam avatar Aug 15 '24 06:08 Avasam