typeshed icon indicating copy to clipboard operation
typeshed copied to clipboard

Update assertpy/extracting.pyi so that kwargs are not required

Open bjhargrave opened this issue 1 year ago • 1 comments

The recent change to better type the sort and filter kwargs had the side effect of making them required. So we fix to supply a default value for the typing enabling them to be optional.

Using None as the default value is not possible for filter which treats None as filtering out everything while the absence of the filter key should mean filtering out nothing. So the typing for filter should allow a None value type as the behavior of None is not specified. So instead we use an empty mapping as the default for typing.

bjhargrave avatar Jun 27 '24 15:06 bjhargrave

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

github-actions[bot] avatar Jun 27 '24 15:06 github-actions[bot]

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

github-actions[bot] avatar Jul 02 '24 16:07 github-actions[bot]