typeshed icon indicating copy to clipboard operation
typeshed copied to clipboard
verified publisher icon python

WebOb: Complete the stubs and activate stricter pyright config

Open Daverball opened this issue 1 year ago • 4 comments

This adds the final little bibs and bobs that were still missing.

I'll readily admit I went a little bit insane writing the stubs for webob.dec.wsgify, so reviewing this one might be a little tough, I did add some tests though to increase confidence, source code can be found here: https://github.com/Pylons/webob/blob/1.8.7/src/webob/dec.py

Daverball avatar Feb 21 '24 17:02 Daverball

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

github-actions[bot] avatar Feb 21 '24 17:02 github-actions[bot]

I'll have a look at what pyright is unhappy with in the test cases later.

Daverball avatar Feb 21 '24 18:02 Daverball

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

github-actions[bot] avatar Feb 22 '24 07:02 github-actions[bot]

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

github-actions[bot] avatar Feb 22 '24 07:02 github-actions[bot]

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

github-actions[bot] avatar Feb 28 '24 07:02 github-actions[bot]

Do you have a minimal repro of the pyright issue that caused you to comment out some cases? I tried a simpler version in the pyright playground but couldn't reproduce it.

Unfortunately I cannot reproduce it with a simpler version on pyright playground either

Daverball avatar Feb 28 '24 08:02 Daverball