typeshed icon indicating copy to clipboard operation
typeshed copied to clipboard

`tensorflow`: Add missing members to the `tensorflow.keras.layers` module.

Open hoel-bagard opened this issue 2 years ago β€’ 48 comments

Some of the added stubs are taken from here.

hoel-bagard avatar Jan 28 '24 09:01 hoel-bagard

According to mypy_primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

github-actions[bot] avatar Jan 28 '24 09:01 github-actions[bot]

According to mypy_primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

github-actions[bot] avatar Jan 28 '24 09:01 github-actions[bot]

According to mypy_primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

github-actions[bot] avatar Jan 28 '24 09:01 github-actions[bot]

According to mypy_primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

github-actions[bot] avatar Jan 28 '24 09:01 github-actions[bot]

According to mypy_primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

github-actions[bot] avatar Jan 28 '24 10:01 github-actions[bot]

@hmc-cs-mdrissi I've tried to add the MultiHeadAttention's __call__ to the stubtest_allowlist.txt, but it is still detected as an error. Did I misunderstand how to add functions to the stubtest allowlist ?

Edit: after spending a bunch of time trying to make CI pass without success, I've removed MultiHeadAttention from the PR.

hoel-bagard avatar Jan 28 '24 10:01 hoel-bagard

FYI this has a merge conflict now.

JelleZijlstra avatar Jan 31 '24 04:01 JelleZijlstra

According to mypy_primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

github-actions[bot] avatar Jan 31 '24 10:01 github-actions[bot]

According to mypy_primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

github-actions[bot] avatar Jan 31 '24 10:01 github-actions[bot]

According to mypy_primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

github-actions[bot] avatar Jan 31 '24 13:01 github-actions[bot]

According to mypy_primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

github-actions[bot] avatar Jan 31 '24 13:01 github-actions[bot]

According to mypy_primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

github-actions[bot] avatar Jan 31 '24 13:01 github-actions[bot]

According to mypy_primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

github-actions[bot] avatar Jan 31 '24 14:01 github-actions[bot]

@hmc-cs-mdrissi Quite a few things from your stubs are only present in tensorflow 2.15, would it be ok to bump the stubs' tensorflow version ? (in another PR, since it breaks a few things)

hoel-bagard avatar Jan 31 '24 14:01 hoel-bagard

According to mypy_primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

github-actions[bot] avatar Jan 31 '24 14:01 github-actions[bot]

Quite a few things from your stubs are only present in tensorflow 2.15, would it be ok to bump the stubs' tensorflow version ?

Yes, we generally aim for the latest version. And agree it should be done in a separate PR :)

JelleZijlstra avatar Jan 31 '24 15:01 JelleZijlstra

Yes feel free to bump the tf version in it's own pr. Stubtest will fail on new arguments and need some methods fixed. Usually filling in new arguments for stubtest is main work needed for upgrading version.

hmc-cs-mdrissi avatar Jan 31 '24 19:01 hmc-cs-mdrissi

I'll do that then!

hoel-bagard avatar Feb 01 '24 00:02 hoel-bagard

According to mypy_primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

github-actions[bot] avatar Feb 01 '24 03:02 github-actions[bot]

According to mypy_primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

github-actions[bot] avatar Feb 01 '24 03:02 github-actions[bot]

According to mypy_primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

github-actions[bot] avatar Feb 04 '24 04:02 github-actions[bot]

According to mypy_primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

github-actions[bot] avatar Feb 04 '24 08:02 github-actions[bot]

According to mypy_primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

github-actions[bot] avatar Feb 05 '24 14:02 github-actions[bot]

According to mypy_primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

github-actions[bot] avatar Feb 08 '24 13:02 github-actions[bot]

This has been a busy work week. I’ll take a pass over all your open prs that I haven’t already approved tomorrow.

hmc-cs-mdrissi avatar Feb 09 '24 04:02 hmc-cs-mdrissi

Thanks! Make sure to take time to rest.

hoel-bagard avatar Feb 09 '24 09:02 hoel-bagard

According to mypy_primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

github-actions[bot] avatar Feb 17 '24 05:02 github-actions[bot]

@JelleZijlstra I don't understand why the CI is failing. It was passing after your merge commit, so I tried to revert the test commit I did earlier. This caused the CI to fail again, so I removed it, and now the CI is failing on the merge commit.

Is it some kind of caching issue ?

hoel-bagard avatar Feb 17 '24 05:02 hoel-bagard

According to mypy_primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

github-actions[bot] avatar Feb 17 '24 05:02 github-actions[bot]

Some weird pytype issue, I'm unfortunately not sure how to address that. Seems like it also failed on the merge commit, though?

JelleZijlstra avatar Feb 17 '24 05:02 JelleZijlstra