Remove Windows checks from curses
Curses is available on Windows through a patch via the windows-curses package. See discussion in #6749.
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
Could you add some comments explaining the unusual situation here? (https://github.com/python/typeshed/pull/6749#issuecomment-1529012238)
Sure, I already added a comment in _curses.pyi but I'll add one in the top-level module too.
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
I think we should just fix the conflicts and merge this. After a couple months of no progress, it seems like the "right" thing won't happen any time soon, and it's time to instead go with the practical thing and just give people the autocompletions and type checking they want.
We can always come up with a better solution for specifying platforms later, and add back the if statements if it then makes sense.
Why is this pr still open and the check for windows in _curses.pyi if sys.platform != win32 hasn't been removed yet?
This is easiest to review locally by telling git to ignore whitespace:
$ git diff -w origin/main HEAD
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
Thanks for doing this, and sorry it took us so long :)
Thank you for having listened to us Windows programmers 👍🏻🙏🏻