typeshed icon indicating copy to clipboard operation
typeshed copied to clipboard

Remove Windows checks from curses

Open rmccampbell opened this issue 2 years ago • 6 comments

Curses is available on Windows through a patch via the windows-curses package. See discussion in #6749.

rmccampbell avatar Jan 04 '24 23:01 rmccampbell

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

github-actions[bot] avatar Jan 04 '24 23:01 github-actions[bot]

Could you add some comments explaining the unusual situation here? (https://github.com/python/typeshed/pull/6749#issuecomment-1529012238)

JelleZijlstra avatar Jan 05 '24 02:01 JelleZijlstra

Sure, I already added a comment in _curses.pyi but I'll add one in the top-level module too.

rmccampbell avatar Jan 05 '24 03:01 rmccampbell

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

github-actions[bot] avatar Jan 05 '24 03:01 github-actions[bot]

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

github-actions[bot] avatar Jan 06 '24 07:01 github-actions[bot]

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

github-actions[bot] avatar Jan 06 '24 07:01 github-actions[bot]

I think we should just fix the conflicts and merge this. After a couple months of no progress, it seems like the "right" thing won't happen any time soon, and it's time to instead go with the practical thing and just give people the autocompletions and type checking they want.

We can always come up with a better solution for specifying platforms later, and add back the if statements if it then makes sense.

Akuli avatar Mar 24 '24 00:03 Akuli

Why is this pr still open and the check for windows in _curses.pyi if sys.platform != win32 hasn't been removed yet?

TheStef56 avatar Apr 06 '24 10:04 TheStef56

This is easiest to review locally by telling git to ignore whitespace:

$ git diff -w origin/main HEAD

Akuli avatar Apr 06 '24 14:04 Akuli

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

github-actions[bot] avatar Apr 06 '24 14:04 github-actions[bot]

Thanks for doing this, and sorry it took us so long :)

Thank you for having listened to us Windows programmers 👍🏻🙏🏻

TheStef56 avatar Apr 06 '24 14:04 TheStef56