typeshed
typeshed copied to clipboard
python
Rework redis/asyncio/{connection,sentinel}.pyi
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
I have no time to look into the pytype error at the moment. @rchen152: Could have a look? Otherwise I'll try to narrow the problem down tomorrow.
The pytype fix was fairly straightforward: Remove the quotes around bound types from the TypeVar, which is cleaner anyway:
https://github.com/python/typeshed/pull/10370/commits/45482b5cecfc71cae0766de9b5382bcf9b46e091
Diff from mypy_primer, showing the effect of this PR on open source code:
vision (https://github.com/pytorch/vision): typechecking got 2.80x faster (19.1s -> 6.8s)
(Performance measurements are based on a single noisy sample)
manticore (https://github.com/trailofbits/manticore): typechecking got 2.42x faster (44.9s -> 18.6s)
(Performance measurements are based on a single noisy sample)
pandas (https://github.com/pandas-dev/pandas): typechecking got 2.59x faster (234.8s -> 90.5s)
(Performance measurements are based on a single noisy sample)
Sorry this PR has been sitting here for so long. There is a fairly big merge conflict; if you fix that I'll review it.
