python-docs-ja icon indicating copy to clipboard operation
python-docs-ja copied to clipboard

:green_heart: Let's move from Travis to GitHubAction.

Open tkoyama010 opened this issue 5 years ago • 5 comments

Hi all. How about moving CI from Travis to GitHubActions? Let me know what you think.

tkoyama010 avatar Apr 04 '20 00:04 tkoyama010

FYI this repository is good. This yml may be helpful.

tkoyama010 avatar Apr 04 '20 00:04 tkoyama010

Requirements of CI build is described in the wiki page. Besides, I have a plan of PR build to display documentation built from source files that PR merged.

Please help me with an assessment.

GitHub Action

Pros.

  • Easily recognize types of event
  • Many GitHub Actions already exist are available
  • automatic GITHUB_TOKEN creation and expiration
  • ?

Cons.

  • It turns out that each step in a job is executed in a sort-of separate environment, and one step is unable to export environment variables that another step could read.
  • ref. https://bravelab.io/blog/migrating-from-travisci-to-github-actions-1/
  • An environment variable is hard to store an SSH key file.
  • ?

Unknown.

  • Can GitHub Action fully satisfy the requirements above?
  • Is storing secrets easier than Travis ci?
  • Can access across repositories easier?
  • ?

cocoatomo avatar Apr 04 '20 01:04 cocoatomo

The feature of automatic GITHUB_TOKEN creation is very helpful to push the results of PR builds. Moreover, the tokens have existence time limits, 60 minutes.

cocoatomo avatar May 09 '20 01:05 cocoatomo

Two workflows, pr_build.yml and delete_pr_built_doc.yml, are now working!

cocoatomo avatar May 17 '20 07:05 cocoatomo

Hi there. I landed in here while checking the Travis solution. Is Travis run manually or scheduled ? I see that all branches' last build happened 4 months ago, hence some fixes to the docs are not available in Transifex for translation.

In the spirit of the pros and cons, GitHub Actions features on.schedule events that are cron-like syntaxes, allowing to run the workflow daily.

rffontenelle avatar Dec 21 '21 01:12 rffontenelle

GitHub Actions are now in use. Should this be closed?

rffontenelle avatar Sep 19 '22 02:09 rffontenelle

Yes. Thanks.

tkoyama010 avatar Sep 19 '22 02:09 tkoyama010