miss-islington icon indicating copy to clipboard operation
miss-islington copied to clipboard

Include new option in cherry-picker config dict

Open Jackenmen opened this issue 2 years ago • 2 comments

This will be necessary when https://github.com/python/cherry-picker/pull/70 is merged. It would maybe be somewhat better to use cherry_picker.load_config() (or simply not specify the config which will default to the equivalent cherry_picker.DEFAULT_CONFIG) instead of hard-coding the configuration but I opted to just keep this consistent with what's already in the code base.

Since this project doesn't pin the version of cherry-picker, the merge of this will need to happen before the merge of the aforementioned PR. I haven't received feedback on the name of this config option though so I'm not entirely sure if it will stay like this.

Jackenmen avatar Aug 27 '23 23:08 Jackenmen

It seems that this is failing due to an unrelated CI issue, see #640 for a fix.

Jackenmen avatar Aug 27 '23 23:08 Jackenmen

Codecov Report

Merging #639 (5a1fb95) into main (ed3aa6a) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #639   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          356       356           
  Branches        29        29           
=========================================
  Hits           356       356           
Flag Coverage Δ
Python_3.10 100.00% <ø> (ø)
Python_3.11 100.00% <ø> (ø)
Python_3.9 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Aug 28 '23 08:08 codecov[bot]