cpython icon indicating copy to clipboard operation
cpython copied to clipboard

gh-71759: Deprecate using bytes-like objects in builtins.

Open serhiy-storchaka opened this issue 8 years ago • 6 comments

Deprecate using bytes-like objects except bytes and bytearray in builtins int(), float(), compile(), eval() and exec().

  • Issue: gh-71759

serhiy-storchaka avatar Mar 23 '17 09:03 serhiy-storchaka

@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ericvsmith, @benjaminp and @mdickinson to be potential reviewers.

mention-bot avatar Mar 23 '17 09:03 mention-bot

@serhiy-storchaka did you still want to pursue this?

brettcannon avatar Mar 22 '19 18:03 brettcannon

I am not sure. Removing support of general object providing the buffer protocol will simplify the code, but what if somebody needs it?

serhiy-storchaka avatar Mar 28 '19 14:03 serhiy-storchaka

@serhiy-storchaka yeah, I don't have a good answer. I guess either ask on python-dev or close this PR to err on the side of backwards-compatibility.

brettcannon avatar Mar 28 '19 21:03 brettcannon

This PR is stale because it has been open for 30 days with no activity.

github-actions[bot] avatar Feb 19 '22 00:02 github-actions[bot]

This PR is stale because it has been open for 30 days with no activity.

github-actions[bot] avatar Aug 28 '22 00:08 github-actions[bot]

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

bedevere-bot avatar Nov 29 '22 19:11 bedevere-bot

This PR is stale because it has been open for 30 days with no activity.

github-actions[bot] avatar Jan 03 '23 00:01 github-actions[bot]

Thanks @hauntsaninja .

I think the discussion above between @serhiy-storchaka and @brettcannon is still unresolved. Not sure whether we will go ahead with this PR.

iritkatriel avatar Feb 09 '23 08:02 iritkatriel

This PR is stale because it has been open for 30 days with no activity.

github-actions[bot] avatar Mar 21 '23 00:03 github-actions[bot]

I guess either ask on python-dev or close this PR to err on the side of backwards-compatibility.

As the years go by, the current behaviour becomes more entrenched and backwards compatibility more important. Let's keep the status quo.

I'll close this PR next week if there are no objections.

encukou avatar Mar 15 '24 14:03 encukou