cpython icon indicating copy to clipboard operation
cpython copied to clipboard

Add platform.android_ver() to test.pythoninfo for Android platforms

Open 490c593f-f636-409f-bb35-6abeb38a4595 opened this issue 8 years ago • 4 comments

BPO 32210
Nosy @vstinner, @xdegaye, @moreati
Dependencies
  • bpo-26855: android: add platform.android_ver()
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2017-12-04.09:39:35.000>
    labels = ['type-feature', '3.7', 'build']
    title = 'Add platform.android_ver()  to test.pythoninfo for Android platforms'
    updated_at = <Date 2017-12-05.16:34:30.711>
    user = 'https://github.com/xdegaye'
    

    bugs.python.org fields:

    activity = <Date 2017-12-05.16:34:30.711>
    actor = 'xdegaye'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Cross-Build']
    creation = <Date 2017-12-04.09:39:35.000>
    creator = 'xdegaye'
    dependencies = ['26855']
    files = []
    hgrepos = []
    issue_num = 32210
    keywords = []
    message_count = 4.0
    messages = ['307544', '307581', '307602', '307657']
    nosy_count = 3.0
    nosy_names = ['vstinner', 'xdegaye', 'Alex.Willmer']
    pr_nums = []
    priority = 'normal'
    resolution = None
    stage = 'needs patch'
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue32210'
    versions = ['Python 3.7']
    

    • The NDK version can be obtained by parsing the file $ANDROID_NDK_ROOT/source.properties.
    • The versions of the SDK build-tools, emulator and platform-tools packages as well as those of the system images can be obtained by parsing the output of "$ANDROID_SDK_ROOT/tools/bin/sdkmanager --list".

    Maybe add a collect_android() function which would exit early if sys.getandroidapilevel() doesn't exist?

    • The NDK version can be obtained by parsing the file $ANDROID_NDK_ROOT/source.properties.
    • The versions of the SDK build-tools, emulator and platform-tools packages as well as those of the system images can be obtained by parsing the output of "$ANDROID_SDK_ROOT/tools/bin/sdkmanager --list".

    You are free to add whatever you want/need, but just try to handle properly errors to collect other info even if these data cannot be read.

    vstinner avatar Dec 04 '17 16:12 vstinner

    Oh, I forgot that pythoninfo already has:

    call_func(info_add, 'sys.androidapilevel', sys, 'getandroidapilevel')
    

    Well, that's the *build time* API level, not the most useful one, but still useful.

    vstinner avatar Dec 04 '17 22:12 vstinner

    The NDK version may be printed by the pythoninfo make target before test.pythoninfo is run on Android.

    platform.android_ver() (not yet implemented, see bpo-26855) must be added to collect_sys() in test.pythoninfo.