gh-91227: Ignore ERROR_PORT_UNREACHABLE

[esoma]

https://github.com/python/cpython/issues/91227

• Issue: gh-91227

[esoma]

@asvetlov @1st1 Friendly ping to see if I can get some feedback on this PR/issue.

[msansoni]

Afternoon @asvetlov @1st1, can we help to get this PR merged?

[serhiy-storchaka]

I apologize for the fact that this PR did not receive due attention. There are currently conflicts between this PR and the main branch. Please resolve conflicts and add tests, if it is possible, and a NEWS entry.

[esoma]

I'll note some things about the test:

• It's the reproducer for the original issue
• I ran it against main and it fails as expected (with a timeout)
• It does not test the recvfrom_into path. I could probably add tests for recvfrom and recvfrom_into to the test.test_asyncio.test_sock_lowlevel if desired.

[esoma]

@serhiy-storchaka If you're not the right person to ping on this, sorry about that, just hoping this doesn't collect dust again.

[bedevere-app[bot]]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[esoma]

I have made the requested changes; please review again

@serhiy-storchaka I've been unable to replicate the resource warning (maybe I'm missing a flag when running the tests?), but I believe it is resolved.

As for the -OO failure, whoops, been using pytest so long using assert has become habit 😄

[bedevere-app[bot]]

Thanks for making the requested changes!

@willingc, @serhiy-storchaka: please review the changes made to this pull request.

[esoma]

If there are questions I'm happy to (try) to answer them.

[bedevere-bot]

:warning::warning::warning: Buildbot failure :warning::warning::warning:

Hi! The buildbot s390x Fedora 3.x has failed when building commit f11d0d8be8af28e1368c3c7c116218cf65ddf93e.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/223/builds/5581) and take a look at the build logs.
4. Check if the failure is related to this commit (f11d0d8be8af28e1368c3c7c116218cf65ddf93e) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/223/builds/5581

Failed tests:

• test.test_multiprocessing_spawn.test_processes

Summary of the results of the build (if available):

==

Click to see traceback logs

remote: Enumerating objects: 16, done.        
remote: Counting objects:   6% (1/15)        
remote: Counting objects:  13% (2/15)        
remote: Counting objects:  20% (3/15)        
remote: Counting objects:  26% (4/15)        
remote: Counting objects:  33% (5/15)        
remote: Counting objects:  40% (6/15)        
remote: Counting objects:  46% (7/15)        
remote: Counting objects:  53% (8/15)        
remote: Counting objects:  60% (9/15)        
remote: Counting objects:  66% (10/15)        
remote: Counting objects:  73% (11/15)        
remote: Counting objects:  80% (12/15)        
remote: Counting objects:  86% (13/15)        
remote: Counting objects:  93% (14/15)        
remote: Counting objects: 100% (15/15)        
remote: Counting objects: 100% (15/15), done.        
remote: Compressing objects:   7% (1/13)        
remote: Compressing objects:  15% (2/13)        
remote: Compressing objects:  23% (3/13)        
remote: Compressing objects:  30% (4/13)        
remote: Compressing objects:  38% (5/13)        
remote: Compressing objects:  46% (6/13)        
remote: Compressing objects:  53% (7/13)        
remote: Compressing objects:  61% (8/13)        
remote: Compressing objects:  69% (9/13)        
remote: Compressing objects:  76% (10/13)        
remote: Compressing objects:  84% (11/13)        
remote: Compressing objects:  92% (12/13)        
remote: Compressing objects: 100% (13/13)        
remote: Compressing objects: 100% (13/13), done.        
remote: Total 16 (delta 2), reused 3 (delta 2), pack-reused 1        
From https://github.com/python/cpython
 * branch                  main       -> FETCH_HEAD
Note: switching to 'f11d0d8be8af28e1368c3c7c116218cf65ddf93e'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at f11d0d8be8 gh-91227: Ignore ERROR_PORT_UNREACHABLE in proactor recvfrom() (#32011)
Switched to and reset branch 'main'

make: *** [Makefile:2204: buildbottest] Error 2

[bedevere-bot]

:warning::warning::warning: Buildbot failure :warning::warning::warning:

Hi! The buildbot AMD64 RHEL8 FIPS Only Blake2 Builtin Hash 3.x has failed when building commit f11d0d8be8af28e1368c3c7c116218cf65ddf93e.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/469/builds/7667) and take a look at the build logs.
4. Check if the failure is related to this commit (f11d0d8be8af28e1368c3c7c116218cf65ddf93e) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/469/builds/7667

Failed tests:

• test.test_multiprocessing_fork.test_processes
• test.test_multiprocessing_forkserver.test_processes

Summary of the results of the build (if available):

==

Click to see traceback logs

remote: Enumerating objects: 16, done.        
remote: Counting objects:   6% (1/15)        
remote: Counting objects:  13% (2/15)        
remote: Counting objects:  20% (3/15)        
remote: Counting objects:  26% (4/15)        
remote: Counting objects:  33% (5/15)        
remote: Counting objects:  40% (6/15)        
remote: Counting objects:  46% (7/15)        
remote: Counting objects:  53% (8/15)        
remote: Counting objects:  60% (9/15)        
remote: Counting objects:  66% (10/15)        
remote: Counting objects:  73% (11/15)        
remote: Counting objects:  80% (12/15)        
remote: Counting objects:  86% (13/15)        
remote: Counting objects:  93% (14/15)        
remote: Counting objects: 100% (15/15)        
remote: Counting objects: 100% (15/15), done.        
remote: Compressing objects:   7% (1/13)        
remote: Compressing objects:  15% (2/13)        
remote: Compressing objects:  23% (3/13)        
remote: Compressing objects:  30% (4/13)        
remote: Compressing objects:  38% (5/13)        
remote: Compressing objects:  46% (6/13)        
remote: Compressing objects:  53% (7/13)        
remote: Compressing objects:  61% (8/13)        
remote: Compressing objects:  69% (9/13)        
remote: Compressing objects:  76% (10/13)        
remote: Compressing objects:  84% (11/13)        
remote: Compressing objects:  92% (12/13)        
remote: Compressing objects: 100% (13/13)        
remote: Compressing objects: 100% (13/13), done.        
remote: Total 16 (delta 2), reused 3 (delta 2), pack-reused 1        
From https://github.com/python/cpython
 * branch                    main       -> FETCH_HEAD
Note: switching to 'f11d0d8be8af28e1368c3c7c116218cf65ddf93e'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at f11d0d8be8a gh-91227: Ignore ERROR_PORT_UNREACHABLE in proactor recvfrom() (#32011)
Switched to and reset branch 'main'

make: *** [Makefile:2203: buildbottest] Error 2

[gvanrossum]

Don't worry about the buildbot failures. I think they are something introduced recently when incremental GC was added. See https://github.com/python/cpython/issues/108362#issuecomment-2016583997.

[miss-islington-app[bot]]

Thanks @esoma for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. 🐍🍒⛏🤖

[miss-islington-app[bot]]

Thanks @esoma for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. 🐍🍒⛏🤖

[miss-islington-app[bot]]

Sorry, @esoma and @gvanrossum, I could not cleanly backport this to 3.11 due to a conflict. Please backport using cherry_picker on command line.

cherry_picker f11d0d8be8af28e1368c3c7c116218cf65ddf93e 3.11

[bedevere-app[bot]]

GH-117209 is a backport of this pull request to the 3.12 branch.

[bedevere-app[bot]]

GH-117210 is a backport of this pull request to the 3.11 branch.