cpython icon indicating copy to clipboard operation
cpython copied to clipboard

gh-142461: Move misplaced NEWS entries to an appropriate section

Open Aniketsy opened this issue 1 month ago • 5 comments

This includes changes in 3.10 and 3.11.

  • Issue: gh-142461

Aniketsy avatar Jan 04 '26 06:01 Aniketsy

Update your branch to fix the CI.

StanFromIreland avatar Jan 04 '26 09:01 StanFromIreland

There are wrong changes. Zip is a built-in for instance. The ast module is a core module IIRC.

picnixz avatar Jan 04 '26 10:01 picnixz

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

bedevere-app[bot] avatar Jan 04 '26 10:01 bedevere-app[bot]

Thanks, I’ll revisit these and also correct them in the previous PR

Aniketsy avatar Jan 04 '26 10:01 Aniketsy

I’d like to apologize for increasing the review workload.

Aniketsy avatar Jan 04 '26 11:01 Aniketsy

@python/organization-owners Please block @Bjorka13 for spam review. TiA.

picnixz avatar Jan 06 '26 09:01 picnixz

@serhiy-storchaka Thanks for the review. I’ve applied the changes based on your suggestions.

Aniketsy avatar Jan 09 '26 14:01 Aniketsy

You need to update your branch to fix the CI.

StanFromIreland avatar Jan 09 '26 17:01 StanFromIreland

@picnixz, have your comments been addressed?

serhiy-storchaka avatar Jan 12 '26 16:01 serhiy-storchaka

Yes they were. Thank you!

picnixz avatar Jan 12 '26 18:01 picnixz

Thanks @Aniketsy for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. 🐍🍒⛏🤖

miss-islington-app[bot] avatar Jan 12 '26 18:01 miss-islington-app[bot]

Thanks @Aniketsy for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. 🐍🍒⛏🤖

miss-islington-app[bot] avatar Jan 12 '26 18:01 miss-islington-app[bot]

GH-143745 is a backport of this pull request to the 3.13 branch.

bedevere-app[bot] avatar Jan 12 '26 18:01 bedevere-app[bot]

GH-143746 is a backport of this pull request to the 3.14 branch.

bedevere-app[bot] avatar Jan 12 '26 18:01 bedevere-app[bot]