gh-140025: Fix `queue.SimpleQueue.__sizeof__()`
- Update SimpleQueue.sizeof() to include the memory used by its internal buffer.
- add a unit test.
Please let me know if my approach or fix needs any improvements . I’m open to feedback and happy to make changes based on suggestions. Thankyou !
- Issue: gh-140025
@colesbury thanks for the feedback. i've applied changes as per suggestions, please let me know if this needs further improvement.
thanks for the feedback. i've applied changes as per suggestions, please let me know if this needs further improvement.
Please make it so that the CI is green before requesting a new review.
@picnixz ci is now green. @colesbury could you please review now if you get a chance. Thanks!
:warning::warning::warning: Buildbot failure :warning::warning::warning:
Hi! The buildbot AMD64 Debian root 3.x (tier-1) has failed when building commit f3e069a7ab8b0594508c998da88937e3aab46451.
What do you need to do:
- Don't panic.
- Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
- Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/345/builds/13136) and take a look at the build logs.
- Check if the failure is related to this commit (f3e069a7ab8b0594508c998da88937e3aab46451) or if it is a false positive.
- If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.
You can take a look at the buildbot page here:
https://buildbot.python.org/#/builders/345/builds/13136
Summary of the results of the build (if available):
==
Click to see traceback logs
Traceback (most recent call last):
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 946, in gc_collect
gc.collect()
~~~~~~~~~~^^
ResourceWarning: unclosed file <_io.FileIO name=13 mode='wb' closefd=True>
Traceback (most recent call last):
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 946, in gc_collect
gc.collect()
~~~~~~~~~~^^
ResourceWarning: unclosed file <_io.FileIO name=11 mode='wb' closefd=True>