cpython icon indicating copy to clipboard operation
cpython copied to clipboard

gh-142972: Document arbitrary ordering in `Path.glob`

Open johnslavik opened this issue 2 months ago • 8 comments

  • Issue: gh-142972

📚 Documentation preview 📚: https://cpython-previews--143025.org.readthedocs.build/

johnslavik avatar Dec 20 '25 18:12 johnslavik

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

bedevere-app[bot] avatar Dec 20 '25 19:12 bedevere-app[bot]

I would say 'unordered' or 'no ordering guarantees'. Please also add the note to rglob().

Thanks. Would you also like me to correct the glob module documention to use the same wording? This is what's in glob docs rn (GH-140184): https://github.com/python/cpython/blob/ec269e1e3fecaad2545e95da52b4f6565e0858bf/Doc/library/glob.rst#L28-L31

johnslavik avatar Dec 20 '25 19:12 johnslavik

I have made the requested changes; please review again

johnslavik avatar Dec 20 '25 19:12 johnslavik

Thanks for making the requested changes!

@AA-Turner: please review the changes made to this pull request.

bedevere-app[bot] avatar Dec 20 '25 19:12 bedevere-app[bot]

Oh, fine: in that case just reuse the exact wording (ie drop 'akin' etc)

A

AA-Turner avatar Dec 20 '25 20:12 AA-Turner

I have made the requested changes; please review again

johnslavik avatar Dec 20 '25 21:12 johnslavik

Thanks for making the requested changes!

@AA-Turner: please review the changes made to this pull request.

bedevere-app[bot] avatar Dec 20 '25 21:12 bedevere-app[bot]

@AA-Turner I think we can merge? :)

johnslavik avatar Jan 01 '26 21:01 johnslavik

Thanks @johnslavik for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. 🐍🍒⛏🤖

miss-islington-app[bot] avatar Jan 11 '26 19:01 miss-islington-app[bot]

GH-143709 is a backport of this pull request to the 3.14 branch.

bedevere-app[bot] avatar Jan 11 '26 19:01 bedevere-app[bot]

GH-143710 is a backport of this pull request to the 3.13 branch.

bedevere-app[bot] avatar Jan 11 '26 19:01 bedevere-app[bot]