cpython icon indicating copy to clipboard operation
cpython copied to clipboard

GH-125789: fix `fut._callbacks` to always return a copy of callbacks

Open kumaraditya303 opened this issue 1 year ago • 1 comments

  • Issue: gh-125789

kumaraditya303 avatar Oct 24 '24 14:10 kumaraditya303


== Tests result: SUCCESS ==

1 test skipped:
    test_asyncio.test_unix_events

30 tests OK.

Total duration: 6 min 8 sec
Total tests: run=2,242 skipped=74
Total test files: run=31/31 skipped=1
Result: SUCCESS

Refleak tested

kumaraditya303 avatar Oct 24 '24 14:10 kumaraditya303

I would add a test for that (e.g., one of the test that Nico wrote with the evil classes) to see that the interpreter does not crash anymore.

I think it is more appropriate to add that to your PR which fixes the UAF issues.

kumaraditya303 avatar Oct 25 '24 12:10 kumaraditya303

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. 🐍🍒⛏🤖

miss-islington-app[bot] avatar Oct 25 '24 12:10 miss-islington-app[bot]

Sorry, @kumaraditya303, I could not cleanly backport this to 3.13 due to a conflict. Please backport using cherry_picker on command line.

cherry_picker cae853e3b44cd5cb033b904e163c490dd28bc30a 3.13

miss-islington-app[bot] avatar Oct 25 '24 12:10 miss-islington-app[bot]

Sorry, @kumaraditya303, I could not cleanly backport this to 3.12 due to a conflict. Please backport using cherry_picker on command line.

cherry_picker cae853e3b44cd5cb033b904e163c490dd28bc30a 3.12

miss-islington-app[bot] avatar Oct 25 '24 12:10 miss-islington-app[bot]

GH-125976 is a backport of this pull request to the 3.13 branch.

bedevere-app[bot] avatar Oct 25 '24 12:10 bedevere-app[bot]