cpython icon indicating copy to clipboard operation
cpython copied to clipboard

gh-119205: Fix autocompletion bug in new repl

Open koxudaxi opened this issue 1 year ago • 3 comments

If the interpreter shows a warning, the new repl prompt cursor moves after the warning.

  • Issue: gh-119205

koxudaxi avatar May 20 '24 16:05 koxudaxi

All commit authors signed the Contributor License Agreement.
CLA signed

ghost avatar May 20 '24 16:05 ghost

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app[bot] avatar May 20 '24 16:05 bedevere-app[bot]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app[bot] avatar May 20 '24 16:05 bedevere-app[bot]

@koxudaxi Can you please rebase onto main and move the tests to the newly created test_pyrepl directory?

lysnikolaou avatar May 21 '24 17:05 lysnikolaou

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app[bot] avatar May 21 '24 18:05 bedevere-app[bot]

@ambv @lysnikolaou Thank you for reviewing and rebasing my PR. I apologize I was moving to Pittsburgh airport from the conference center.

koxudaxi avatar May 21 '24 19:05 koxudaxi

@koxudaxi let the tests complete, don't rebase unless there are conflicts.

ambv avatar May 21 '24 20:05 ambv

:warning::warning::warning: Buildbot failure :warning::warning::warning:

Hi! The buildbot AMD64 Debian root 3.x has failed when building commit 506b1a3ff66a41c72d205c8e4cba574e439d8e76.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/345/builds/8076) and take a look at the build logs.
  4. Check if the failure is related to this commit (506b1a3ff66a41c72d205c8e4cba574e439d8e76) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/345/builds/8076

Summary of the results of the build (if available):

Click to see traceback logs
Note: switching to '506b1a3ff66a41c72d205c8e4cba574e439d8e76'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 506b1a3ff6 gh-119205: Fix autocompletion bug in new repl (#119229)
Switched to and reset branch 'main'

configure: WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduled for removal in Python 3.15)
configure: WARNING: pkg-config is missing. Some dependencies may not be detected correctly.

make: *** wait: No child processes.  Stop.
make: *** Waiting for unfinished jobs....
make: *** wait: No child processes.  Stop.

Cannot open file '/root/buildarea/3.x.angelico-debian-amd64/build/test-results.xml' for upload

bedevere-bot avatar May 22 '24 00:05 bedevere-bot

The buildbot failure is an unrelated timeout:

command timed out: 1800 seconds without output running [b'make', b'buildbottest', b'TESTOPTS=-j2 --junit-xml test-results.xml ${BUILDBOT_TESTOPTS}', b'TESTPYTHONOPTS=', b'TESTTIMEOUT=1200'], attempting to kill

ambv avatar May 22 '24 02:05 ambv

Thanks @koxudaxi for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. 🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington-app[bot] avatar May 22 '24 15:05 miss-islington-app[bot]

GH-119407 is a backport of this pull request to the 3.13 branch.

bedevere-app[bot] avatar May 22 '24 15:05 bedevere-app[bot]