cpython icon indicating copy to clipboard operation
cpython copied to clipboard

Add import.complete audit event.

Open folded opened this issue 1 year ago • 7 comments

This adds a balancing "import.complete" audit event matching the existing "import" audit event, which allows the audit system to be used to observe programatically the same import timing information that is logged by PYTHONPROFILEIMPORTTIME.

The current import audit event may be fired twice for imports of native modules. The second import event can be distinguished from the first because the second argument is always non-None in this case, whereas it is always None in the first case.

folded avatar May 17 '24 13:05 folded

All commit authors signed the Contributor License Agreement.
CLA signed

ghost avatar May 17 '24 13:05 ghost

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app[bot] avatar May 17 '24 13:05 bedevere-app[bot]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app[bot] avatar May 17 '24 13:05 bedevere-app[bot]

@zooba - Thomas Wouters suggested that you were a good person to tag on this change.

folded avatar May 17 '24 13:05 folded

Is this change small enough that it doesn't need an issue?

nineteendo avatar May 17 '24 15:05 nineteendo

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app[bot] avatar May 20 '24 10:05 bedevere-app[bot]

@nineteendo I'm not sure what the convention is here. I'm happy to create an issue if that's preferred. I'm also aware that there should be a documentation change, which I've added (I hope; the convention for documenting audit events isn't totally clear - especially when they need additional text).

folded avatar May 20 '24 12:05 folded

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app[bot] avatar May 21 '24 14:05 bedevere-app[bot]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app[bot] avatar May 21 '24 14:05 bedevere-app[bot]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app[bot] avatar May 22 '24 11:05 bedevere-app[bot]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app[bot] avatar May 22 '24 11:05 bedevere-app[bot]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app[bot] avatar May 22 '24 11:05 bedevere-app[bot]

This needs a NEWS entry (just a basic Adds an ``import/module`` :ref:`auditing event <auditing>` message) and an issue (which I created for you). This is so it's possible to see from the changelog when it was introduced, and find links back to the PR.

zooba avatar May 22 '24 13:05 zooba