cpython icon indicating copy to clipboard operation
cpython copied to clipboard

gh-99631: Add custom loads and dumps support for the shelve module

Open furkanonder opened this issue 1 year ago • 1 comments

  • Issue: gh-99631

📚 Documentation preview 📚: https://cpython-previews--118065.org.readthedocs.build/

furkanonder avatar Apr 18 '24 19:04 furkanonder

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

bedevere-app[bot] avatar Apr 23 '24 14:04 bedevere-app[bot]

Thank you for the changes, those are much clearer now! I don't have any other comments (by the way, thank you for being reactive and accepting my feedback!)

You're welcome. Thank you so much for your time and effort.

furkanonder avatar Jul 29 '24 10:07 furkanonder

Oof, I forgot to merge main. Well, I don't think something for shelve changed in between and there were no conflicts, so it should be fine. Thanks for waiting!

picnixz avatar Jul 12 '25 12:07 picnixz

Oof, I forgot to merge main. Well, I don't think something for shelve changed in between and there were no conflicts, so it should be fine. Thanks for waiting!

Thanks for the merge!

furkanonder avatar Jul 13 '25 17:07 furkanonder