cpython icon indicating copy to clipboard operation
cpython copied to clipboard

gh-117110: Fix subclasses of typing.Any with custom constructors

Open Azureblade3808 opened this issue 1 year ago • 3 comments

The superclass of typing.Any is object and object.__new__(...) doesn't accept additional argument beyond the first argument cls.

  • Issue: gh-117110

Azureblade3808 avatar Mar 21 '24 07:03 Azureblade3808

All commit authors signed the Contributor License Agreement.
CLA signed

ghost avatar Mar 21 '24 07:03 ghost

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app[bot] avatar Mar 21 '24 07:03 bedevere-app[bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

bedevere-app[bot] avatar Mar 21 '24 08:03 bedevere-app[bot]

Thanks @Azureblade3808 for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. 🐍🍒⛏🤖

miss-islington-app[bot] avatar Mar 29 '24 00:03 miss-islington-app[bot]

GH-117357 is a backport of this pull request to the 3.12 branch.

bedevere-app[bot] avatar Mar 29 '24 00:03 bedevere-app[bot]

GH-117358 is a backport of this pull request to the 3.11 branch.

bedevere-app[bot] avatar Mar 29 '24 00:03 bedevere-app[bot]