trio icon indicating copy to clipboard operation
trio copied to clipboard

Switch to use `uv pip install`

Open CoolCat467 opened this issue 1 year ago • 2 comments

This pull request follows up on #2956 and is attempting to switch the continuous integration system to use astral.sh' new tool uv.

CoolCat467 avatar Feb 16 '24 02:02 CoolCat467

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.63%. Comparing base (6fad505) to head (af258f3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2957   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files         121      121           
  Lines       17839    17839           
  Branches     3206     3206           
=======================================
  Hits        17774    17774           
  Misses         46       46           
  Partials       19       19           

codecov[bot] avatar Feb 16 '24 02:02 codecov[bot]

This seems nontrivial, can we break this into 2 prs?

  1. replace pip-compile
  2. replace pip install

Personally I see (1) as much more valuable-- (2) doesn't change much. Personally I'm more excited by uv's ability to get the lowest compatible version so we can add a new CI run than by it replacing pip install.

A5rocks avatar Feb 16 '24 03:02 A5rocks

Some of your changes remind me that we should probably run shellcheck over our scripts...

Problem is, it's written in haskell and the pre-commit integration for it uses docker, which is a mess

CoolCat467 avatar Aug 14 '24 23:08 CoolCat467

Some of your changes remind me that we should probably run shellcheck over our scripts...

Problem is, it's written in haskell and the pre-commit integration for it uses docker, which is a mess

Yeah I think it's fine not to check it in CI. It's not like our shell scripts are that important or change often; it's just a nicety.

A5rocks avatar Aug 15 '24 01:08 A5rocks