trio-typing icon indicating copy to clipboard operation
trio-typing copied to clipboard

Add 'abandon_on_cancel' to to_thread.run_sync

Open Hnasar opened this issue 1 year ago • 2 comments

A new parameter name was added https://trio.readthedocs.io/en/stable/history.html#id15

Hnasar avatar Sep 16 '24 18:09 Hnasar

Hi!

Thanks for sending this. We should remove the cancellable= argument, which is deprecated (and issues warnings at runtime) along with this addition.

tjstum avatar Sep 17 '24 15:09 tjstum

reminder that trio-typing is not really maintained, as upstream trio has incorporated type hints. Once mypy supports typing Nursery.start we will sunset this repo, see https://github.com/python-trio/trio-typing/issues/75#issuecomment-2189532972

jakkdl avatar Sep 18 '24 09:09 jakkdl

Great, thanks!

tjstum avatar Sep 24 '24 16:09 tjstum

Hey @Hnasar, it looks like that was the first time we merged one of your PRs! Thanks so much! :tada: :birthday:

If you want to keep contributing, we'd love to have you. So, I just sent you an invitation to join the python-trio organization on Github! If you accept, then here's what will happen:

  • Github will automatically subscribe you to notifications on all our repositories. (But you can unsubscribe again if you don't want the spam.)

  • You'll be able to help us manage issues (add labels, close them, etc.)

  • You'll be able to review and merge other people's pull requests

  • You'll get a [member] badge next to your name when participating in the Trio repos, and you'll have the option of adding your name to our member's page and putting our icon on your Github profile (details)

If you want to read more, here's the relevant section in our contributing guide.

Alternatively, you're free to decline or ignore the invitation. You'll still be able to contribute as much or as little as you like, and I won't hassle you about joining again. But if you ever change your mind, just let us know and we'll send another invitation. We'd love to have you, but more importantly we want you to do whatever's best for you.

If you have any questions, well... I am just a humble Python script, so I probably can't help. But please do post a comment here, or in our chat, or on our forum, whatever's easiest, and someone will help you out!

trio-bot[bot] avatar Sep 24 '24 16:09 trio-bot[bot]