social-core icon indicating copy to clipboard operation
social-core copied to clipboard

Implement an OIDC-based backend for uc-cdis/fence

Open VJalili opened this issue 6 years ago • 1 comments

Fence repo: https://github.com/uc-cdis/fence

TODOs:

  • [ ] Fence does not support nonce (see https://github.com/uc-cdis/fence/issues/600 )---a required claim by psa (and oidc specifications)---that results in AuthTokenError exception:

    https://github.com/python-social-auth/social-core/blob/000f8e5c8b505f2215e25deebf670b708a0578f4/social_core/backends/open_id_connect.py#L134-L143

    Hence, either psa should make nonce optional (https://github.com/python-social-auth/social-core/issues/315) or Fence implement it. IMHO, based on OIDC-specs (see the following quote), the latter is preferred.

    If present in the Authentication Request, Authorization Servers MUST include a nonce Claim in the ID Token with the Claim Value being the nonce value sent in the Authentication Request. (Ref)

VJalili avatar Mar 27 '19 17:03 VJalili

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 22 '20 00:03 stale[bot]