poetry icon indicating copy to clipboard operation
poetry copied to clipboard
verified publisher icon python-poetry

Preserve line breaks in poetry.lock (regression)

Open extrwi opened this issue 2 years ago • 7 comments

  • Poetry version: 1.3.2
  • Python version: 3.11.1
  • OS version and name: Windows 10
  • [x] I am on the latest stable Poetry version, installed using a recommended method.
  • [x] I have searched the issues of this repo and believe that this is not a duplicate.
  • [ ] I have consulted the FAQ and blog for any relevant entries or release notes.
  • [ ] If an exception occurs when executing a command, I executed it again in debug mode (-vvv option) and have included the output below.

Issue

When generating poetry.lock in mixed environments (e.g. Windows and Linux), CRLF gets replaced by LF and vice versa. This had already been reported and supposedly fixed before (https://github.com/python-poetry/poetry/issues/1488), but probably regressed during the introduction of tomli (https://github.com/python-poetry/poetry/pull/6562). I couldn't find any special treatment for line endings of poetry.lock in poetry's code.

extrwi avatar Feb 17 '23 11:02 extrwi

Since Windows is no longer UWP, I am not sure it is relevant anymore. What happens if you delete it? Does Windows still launch?

mattleibow avatar Mar 21 '22 17:03 mattleibow

This is used for XAML Hot Reload for WinUI; it's a part of the injection mode for getting our assemblies added to a users project after it's setup and started.

It's 100% required for that to work right now, so we can't get rid of it. But it should only be in Debug builds, if it's showing up in release builds then it shouldn't be and we should get rid of that from it.

And yeah, the name is misleading. It was used for UWP Xamarin.Forms support, but it's also for WinUI, and we didn't change the names around for interop reasons. Technically, it's the same stack.

drasticactions avatar Apr 07 '22 13:04 drasticactions

Action: Verify this is not included in a release build.

Redth avatar Apr 26 '22 14:04 Redth

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

ghost avatar Aug 30 '22 15:08 ghost

This is going to require that we can link windows applications. Right now we can't because WinUI is not marked as trimmable, so the linker fails out the gate.

See also: https://dev.azure.com/microsoft/OS/_workitems/edit/35181693/

mattleibow avatar Aug 30 '22 15:08 mattleibow

@chabiss Did your changes for the Bootstrapper address this issue?

drasticactions avatar Mar 01 '23 08:03 drasticactions