rfc3986 icon indicating copy to clipboard operation
rfc3986 copied to clipboard

rfc3986 uses its own deprecated method - warning spam

Open jpmaterial opened this issue 1 year ago • 1 comments

In Version 2.0, in URIMixin.resolve_with() rfc3986 uses the deprecated URIReference.is_valid() instead of a Validator.

Apart from it being a bad look, it causes literally thousands of warnings in our pipeline (since resolve_with() is used often from the json-schema and jschon packages) - see below. This spams our logs and can make it hard to debug.

I made a fix: https://github.com/jpmaterial/rfc3986/tree/release/2.0 (and verified it), but there is no branch that offers itself for a pull request.

Are you interested in the fix (and releasing a 2.0.1 I guess) and if yes, on which branch should I request a pull?

image

jpmaterial avatar Aug 30 '24 12:08 jpmaterial

it seems already fixed in https://github.com/python-hyper/rfc3986/issues/86

sir-sigurd avatar Feb 19 '25 18:02 sir-sigurd