hyperlink icon indicating copy to clipboard operation
hyperlink copied to clipboard

remove "parse_host" API

Open glyph opened this issue 8 years ago • 3 comments

What is the purpose of this API being public? It doesn't seem to connect with anything else in the docs.

glyph avatar Jul 03 '17 06:07 glyph

It's a pretty simple function that might be of some utility. I don't feel very strongly about it, so I'm fine with removing it from the __init__.

mahmoud avatar Jul 03 '17 06:07 mahmoud

Actually, on further reflection, there may be more to consider, toward the bottom of my comment here: https://github.com/python-hyper/hyperlink/issues/26#issuecomment-312566868

mahmoud avatar Jul 03 '17 07:07 mahmoud

APIs like this can have numerous sharp edges; understanding IPv6 is incredibly gnarly even at the best of times, and apparently-useful utilities like this can make it worse, so I'd be keen to avoid exposing it unless there's some reason that users really need it.

glyph avatar Jul 03 '17 07:07 glyph