sir-lancebot icon indicating copy to clipboard operation
sir-lancebot copied to clipboard

Issues fetched by `.hacktoberissues` must have "hacktoberfest" topic in their repo

Open hedyhli opened this issue 5 years ago • 9 comments

Description

hacktoberissues command returns issues, but the repo should also have "hacktoberfest" topic for it to count (and i don't really think a hacktoberfest label is needed but i may be wrong, please let me know)

with current logic, it finds issues with hacktoberfest label, without checking if the repo is even eligible

Possible Solutions

loop through results, only include those that has hacktoberfest topic

Would you like to implement a fix?

Note: For high-priority or critical bugs, fixes may be implemented by staff.

Anyone can implement the bug fix

hedyhli avatar Oct 07 '20 00:10 hedyhli

Yes, it's not just the hacktoberfest topic, but also PRs labeledhacktoberfest-accepted.

ChrisGallardo avatar Oct 07 '20 02:10 ChrisGallardo

@ChrisGallardo @Den4200 i'm talking about fetching issues (.hacktoberissues) command, not PRs, so I don't think #475 fixes this, and I don't think hacktoberfest-accepted label on PRs is related. Am I missing something?

hedyhli avatar Oct 08 '20 05:10 hedyhli

@hedythedev Right, sorry, I misread the issue.

Den4200 avatar Oct 08 '20 11:10 Den4200

Oh I see.

ChrisGallardo avatar Oct 08 '20 22:10 ChrisGallardo

@hedyhli Greetings. I seem to be around a year late to this, but would you still like to implement this fix?

Xithrius avatar Aug 23 '21 07:08 Xithrius

@Xithrius I'm not sure I'll have the time, and I haven't worked with the codebase for quite a while so I might need some getting use to.

Also (for hacktoberfest stats/prs), this year's hacktoberfest (if it's happening) probably doesn't need the "first 3 days counts even if it doesn't haven hacktoberfest label" anymore. Again, I haven't been on discord for a long time nor have I seen the commits and stuff so I'm not sure if that needs to be changed before October.

In any case, I think we should let this issue be open to others, though if I'm lucky I might have time to have a look at it this weekend.

hedyhli avatar Aug 23 '21 12:08 hedyhli

Alright, I'll leave it up for grabs for now.

Xithrius avatar Aug 23 '21 18:08 Xithrius

I can work on this but it's blocked by #919 for now

hedyhli avatar Oct 20 '21 01:10 hedyhli

After rethinking about it I decided it should include two types of issues:

  1. Python repo, has hacktoberfest as an issue label. Doesn't matter if it has hacktoberfest in the repo topics.
  2. Python repo, must have hacktoberfest in the issue's repo topics

This is because they accept PRs where the repo doesn't have the hacktoberfest topic but has the hacktoberfest-accepted label in the PR itself. If an issue has the hacktoberfest label (for type 1), maintainers would probably be willing to add the acceptance label if they don't have hackoberfest topic.

hedyhli avatar Oct 20 '21 10:10 hedyhli